FINERACT-2553: Modernize Integration Test Helpers to use Fineract-Client#5666
FINERACT-2553: Modernize Integration Test Helpers to use Fineract-Client#5666Avtansh88 wants to merge 2 commits intoapache:developfrom
Conversation
|
No proper Jira ticket referenced. Is this a problem we have identified or a spontaneous improvement? In short: no Jira ticket, no PR. Please provide a ticket and format the PR title according to the rules ("FINERACT-1234: Some title here"), thanks. |
|
Hi @vidakovic, thanks for the guidance.I've already requested a Jira account to create the formal ticket for this improvement. It might take a couple of days for approval. Once it's active, I'll link the ticket here and update the PR title accordingly. In the meantime, I'm also working on modernizing other helpers like RolesHelper to ensure consistency. Thanks for your patience. |
Avtansh88
force-pushed
the
gsoc/modernize-user-helper
branch
2 times, most recently
from
4b8d017 to
09a084a
Compare
Avtansh88
changed the title
Avtansh88
force-pushed
the
gsoc/modernize-user-helper
branch
from
09a084a to
0492f18
Compare
|
Hi @vidakovic , I've updated the PR with the Jira ticket FINERACT-2553 and included the modernization for both UserHelper and RolesHelper. The commits are now GPG-verified as well. Looking forward to your feedback when you have a moment. Thanks |
|
@Avtansh88 ... there are still failing tests... ping again when all these are green. |
2 participants
## Description
This PR is a Proof of Concept (PoC) for my GSoC 2026 proposal: "Modernizing Integration Tests with Fineract-Client".
Key Changes:
->UserHelper.java: Refactored legacy RestAssured methods to use type-safe Fineract-Client (Feign).
->RolesHelper.java: Introduced a modern, parameter-less createRole() method to resolve inter-helper dependencies and ensure backward compatibility.
->Type Safety: Replaced manual JSON string building with OpenAPI models like PostUsersRequest and PutUsersUserIdRequest.
->Code Cleanup: Removed redundant RequestSpecification and ResponseSpecification from modernized method signatures.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.